Legacy changelog paths default to CHANGELOG.md #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folded security policy and best practices into the Deployment Guide under a "Security Considerations" section placed after troubleshooting. This keeps the document focused on simple deployment steps first, with more advanced topics and security details at the end. Changes: - Moved security content to end of DEPLOYMENT.md (after troubleshooting) - Updated CONTRIBUTING.md to reference DEPLOYMENT.md#security-considerations - Deleted SECURITY.md to eliminate duplicate documentation 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
…mments Enhanced the changelog suggestion comments with: - Added instruction: "To re-generate this suggestion, delete this comment and make a new commit" - If skip-changelog-labels are configured, show a line: "You can skip my suggestions by adding one of these labels to the PR: xxx, yyy" Applied to both: - _format_suggestion_comment() for generated entries - _format_legacy_conversion_comment() for converted legacy entries 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| - Implemented strict enforcement that prevents lying in your changelog entries (#391) (Oscar Hernandez) | ||
| - Lorem ipsum dolor | ||
| this should be suggested removed | ||
| even if it's many lines (#111) (Jon Blow, Jane Snow) |
There was a problem hiding this comment.
This was converted to logchange format. Let's remove it.
Suggested change
| even if it's many lines (#111) (Jon Blow, Jane Snow) |
|
🔄 I've converted the legacy changelog entry to logchange format! I detected a change to Suggested Logchange Entry for title: Legacy changelog paths default to CHANGELOG.md
type: changed
description: |
Lorem ipsum dolor
this should be suggested removed
even if it's many lines
authors:
- name: Jon Blow
- name: Jane Snow
issues:
- 111What to do next:
Why? |
When users manually edit legacy changelog files, the bot now suggests: 1. Restoring any removed lines (commented on LEFT side of diff) 2. Removing any added lines (commented on RIGHT side of diff) This ensures users don't manually edit these files - they should use the logchange format instead. Changes: - Added extract_removed_lines_with_positions() method to detect removed lines - Updated create_review_comment_with_suggestion() to accept 'side' parameter for commenting on removed (LEFT) or added (RIGHT) lines - Enhanced _post_legacy_removal_suggestions() to handle both types of changes and post separate comments for each group of consecutive lines For example, if a user removes lines 35-37 and 47-50, then adds lines 48-50, the bot will make 3 comments: 1. Restore lines 35-37 2. Restore lines 47-50 3. Remove lines 48-50 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.